test: use unique cluster name to avoid collisions #1479
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
salasberryfin
force-pushed
the
fix-clusterclass-e2e-errors
branch
from
38d4c5c to
dd33d16
Compare
k8s-ci-robot
added
the
cncf-cla: yes
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
fix-clusterclass-e2e-errors
branch
from
dd33d16 to
f17b52a
Compare
|
/retest |
salasberryfin
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind failing-test
What this PR does / why we need it:
Use unique cluster names for each test case to prevent name collisions. Reusing cluster resource names creates a situation where the
Clusterobject may be updated by a different cluster flavor, which may imply that the two definitions are not compatible and a webhook will disallow the change. Thanks @damdo for investigating and getting to the bottom of this.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The same change should be applied to GKE test cases. We can do that in the existing PR #1445, when we're ready to successfully run these tests.
TODOs:
Release note: